feat: tree/path for all metadataResolver use W-20175875#821
Merged
Conversation
shetzel
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
after getting #820 merged, I ran into a similar problem elsewhere, same root cause.
so this pr fixes all the places SDR might have constructed a tree without cwd for MetadataResolver.
with a shared fn for returning the tree/undefined
that
process.env.ESBUILD_PLATFORMis a bundle-time esbuilddefinevalue so that code can be "dropped" when it'll never apply. We use that in other places for web-only stuff in the extensions/libraries (also means it should have no effect outside of our bundled web ext)What issues does this PR fix or reference?
@W-20175875@