Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getting-started): script tag src and link tag href are incorrect #228

Merged
merged 2 commits into from
Sep 6, 2020
Merged

fix(getting-started): script tag src and link tag href are incorrect #228

merged 2 commits into from
Sep 6, 2020

Conversation

hkennyv
Copy link
Contributor

@hkennyv hkennyv commented Sep 5, 2020

closes #227

note: i couldn't build the docs to check because of #192 , so if someone with a working build system wants to check, they can, thank you!

@ko2in
Copy link
Member

ko2in commented Sep 5, 2020

note: i couldn't build the docs to check because of #192 , so if someone with a working build system wants to check, they can, thank you!

You can downgrade doc pad version to v6.79.4. You can upgrade again once you've done with your contributions if you need latest docpad and using for your own projects.

Please refer the contribution guide. I suggest to omit the commands docpad update and docpad upgrade and follow the rest instructions.

@hkennyv
Copy link
Contributor Author

hkennyv commented Sep 6, 2020

yeah, let me give this a try, thanks @ko2in

@lubber-de lubber-de added this to the 2.8.8 milestone Sep 6, 2020
@lubber-de lubber-de added the Fix Pull requests which fix broken examples label Sep 6, 2020
@hkennyv
Copy link
Contributor Author

hkennyv commented Sep 6, 2020

thanks for taking the time to explain to me @ko2in! i definitely glossed over the dist/ note. I've updated my PR!

Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de merged commit 5f5b342 into fomantic:develop Sep 6, 2020
@lubber-de lubber-de modified the milestones: 2.8.8, 2.8.7 Sep 6, 2020
@hkennyv hkennyv deleted the fix/script-tag branch September 6, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Pull requests which fix broken examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting started - link and script have incorrect paths
3 participants