feat(highlight): customise default foreground colour #336
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebszyller
changed the title
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
Rude bot smh |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In my own fork, I'm forcing the foreground colour manually because I like it white regardless of the contrast or
Normalhl. Currently,default_darkanddefault_whiteare hardcoded inM.colors, I think it'd be better if they could be customised from the config.