fix(highlight): return false when the capture is not a comment #275
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. |
github-actions
bot
added
the
stale
geoffreylefebvre
force-pushed
the
fix-jump
branch
2 times, most recently
from
64c92b7 to
0a88a50
Compare
geoffreylefebvre
changed the title
geoffreylefebvre
force-pushed
the
fix-jump
branch
from
0a88a50 to
792f0ad
Compare
geoffreylefebvre
changed the title
geoffreylefebvre
force-pushed
the
fix-jump
branch
2 times, most recently
from
d1958c3 to
35a4d13
Compare
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
bump |
github-actions
bot
removed
the
stale
geoffreylefebvre
force-pushed
the
fix-jump
branch
from
35a4d13 to
8fa36e8
Compare
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
bump |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
bump |
github-actions
bot
removed
the
stale
|
Fixes #301 |
|
This PR is stale because it has been open 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents jump to next/previous todo comment from hitting context.TODO() in go code.
This problems occurs when using a highlight pattern without a colon (e.g. pattern = [[.*<(KEYWORDS)>]]) even when comments_only is true.