feat: Add option to not override highlights #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. |
|
+1 on this PR |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
Would love this |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I opened this pull request in order to address this issue that I created here.
But in summary someone had desired the ability to disable highlights and you gave them a way to do so through the pattern key of the highlight table. It works but I found it breaks some features such as the todo quick fix and todo trouble integration which I would definitely want to use.
I added this as a small change that allows keeping your highlight groups as is for todo comments.
If there's formatting changes or another way you'd like this implemented please let me know. I went with what seemed to be the easiest but still sensible route.