Fix measuring text when OpenType features are passed in to .text() (f…

…oliojs#1492) * Update text.js to fix measuring text when opentype features are passed in to .text() * added simple test * Update CHANGELOG.md --------- Co-authored-by: Libor M. <[email protected]>
foliojs-fork · Dec 31, 2024 · 9838c57 · 9838c57
1 parent df20359
commit 9838c57
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## pdfkit changelog
 
+### Unreleased
+
+- Fix measuring text when OpenType features are passed in to .text()
+
 ### [v0.15.2] - 2024-12-15
 
 - Fix index not counting when rendering ordered lists (#1517)

diff --git a/lib/mixins/text.js b/lib/mixins/text.js
@@ -282,7 +282,7 @@ export default {
     const lineGap = options.lineGap || this._lineGap || 0;
 
     if (!wrapper) {
-      return (this.x += this.widthOfString(text));
+      return (this.x += this.widthOfString(text, options));
     } else {
       return (this.y += this.currentLineHeight(true) + lineGap);
     }

diff --git a/...snapshots__/text-spec-js-text-continued-text-with-open-type-features-1-snap.png b/...snapshots__/text-spec-js-text-continued-text-with-open-type-features-1-snap.png
diff --git a/tests/visual/text.spec.js b/tests/visual/text.spec.js
@@ -92,4 +92,13 @@ describe('text', function() {
       doc.fillColor('#000').list(['One', ['One.One', 'One.Two'], 'Three'], 100, 150, {listType: 'numbered'});
     })
   })
+
+  test('continued text with OpenType features', function() {
+    return runDocTest(function(doc) {
+      doc.font('tests/fonts/Roboto-Regular.ttf');
+      doc.text('Really simple', 100, 100, {features: ['smcp'], continued: true, lineBreak: false})
+      doc.text(' text', {features: [], lineBreak: false});
+    });
+  });
+
 });