MODFQMMGR-1097 Remove the instance classification number index

[mweaver-ebsco]

Purpose

This PR is to remove 4 indexes that don't provide sufficient benefit for their cost. These were recently added and have never been included in any release

Approach

The approach here is to simply remove the creation scripts. Since the indexes were never in any released versions, I did not bother adding scripts to remove the indexes.

Changes Checklist

• API Changes: None
• Database Schema Changes: Removed 4 index creation scripts
• Interface Version Changes: None
• Interface Dependencies: None
• Permissions: None
• Logging: N/A
• Unit Testing: N/A
• Integration Testing: N/A
• Manual Testing: Confirm that changes were tested on local or dev environment.
• NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODFQMMGR-1097

[Copilot]

Pull request overview

This PR removes four recently added (but unreleased) PostgreSQL index-creation snippets for the instance table from the DB schema script registry, eliminating index maintenance cost that reportedly doesn’t provide sufficient benefit.

Changes:

• Removed four instance/*Index.sql snippet references from schema.json.
• Deleted the four corresponding index-creation SQL snippet files.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
mod-inventory-storage-server/src/main/resources/templates/db_scripts/schema.json	Removes the four index snippet entries so they are no longer applied during schema setup/migration.
mod-inventory-storage-server/src/main/resources/templates/db_scripts/instance/createInstanceNotesStaffOnlyIndex.sql	Deletes the index creation snippet for notes staffOnly.
mod-inventory-storage-server/src/main/resources/templates/db_scripts/instance/createInstanceNotesNoteIndex.sql	Deletes the index creation snippet for notes note.
mod-inventory-storage-server/src/main/resources/templates/db_scripts/instance/createInstanceClassificationNumberIndex.sql	Deletes the index creation snippet for classifications.classificationNumber.
mod-inventory-storage-server/src/main/resources/templates/db_scripts/instance/createInstanceAdministrativeNotesIndex.sql	Deletes the index creation snippet for administrativeNotes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mweaver-ebsco]

This was merged (via the GitHub UI, even). I'm not sure why GH is claiming it wasn't...