Rename placeholder on note creation #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can update it if necessary
riccardoferretti
deleted the
fix/1327-rename-placeholder-on-note-creation
branch
|
The editor is super slow after this change for me (specifically v0.25.9), looks like it's recalculating the orphans and other stuff after every change, see this video: I've checked that this doesn't happen in 0.25.8. |
Closed
|
Thanks for reporting this, it's related to one of the side changes, pushing a fix now :) |
|
v0.25.10 should fix this |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1327
Passing to the create-note command a source link, in which case it will check whether, once the note has been created (possibly using a template that changed the name of the original placeholder), the name of the new note matches the originating link - and if not updates it.
I made a conscious decision here to only update the source link, and not all placeholders that match the source link.
Happy to have a conversation about that, for now it felt better this way.
Oh yeah, and I was playing with some logging stuff (minor)