Skip to content

Conversation

@HazardyKnusperkeks
Copy link
Contributor

So clang-tidy is happy if you include <fmt/format.h> for fmt::formatter.

So clang-tidy is happy if you include <fmt/format.h> for fmt::formatter<T>.
@vitaut
Copy link
Contributor

vitaut commented Nov 3, 2025

Thanks for the PR but I don't think it is correct to mark fmt/base.h as a private header in general. Even you consider just fmt::formatter, fmt/base.h is the header that defines it. You only need to include fmt/format.h or other headers like fmt/std.h if you need specializations defined in those headers.

@vitaut vitaut closed this Nov 3, 2025
@HazardyKnusperkeks
Copy link
Contributor Author

I never considered fmt/base.h to be part of the API. But if it is, then everything is fine. Thanks.

@mwinterberg-dtek
Copy link

https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-export

would annotating the "base.h" include with export make everyone happy?

@HazardyKnusperkeks HazardyKnusperkeks deleted the iwyu branch November 6, 2025 20:16
@HazardyKnusperkeks
Copy link
Contributor Author

I'm happy. ;) If clang-tidy would be happy, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants