-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add the K8s agent set up document #6184
base: master
Are you sure you want to change the base?
Conversation
Code Review Agent Run #ddf77fActionable Suggestions - 0Review Details
|
da6aaea
to
f691658
Compare
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6184 +/- ##
==========================================
- Coverage 37.06% 37.06% -0.01%
==========================================
Files 1318 1318
Lines 132644 132644
==========================================
- Hits 49167 49166 -1
- Misses 79228 79229 +1
Partials 4249 4249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #175b17Actionable Suggestions - 0Review Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions.
Thank you for contributing!
Code Review Agent Run #baf2c9Actionable Suggestions - 0Review Details
|
Tracking issue
Related to flyteorg/flytekit#3004
Why are the changes needed?
Adding the documentation for the flyte K8s service agent
What changes were proposed in this pull request?
docs
How was this patch tested?
local sandbox
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
In the doc
Check all the applicable boxes
Related PRs
flyteorg/flytekit#3004
Summary by Bito
Added comprehensive documentation for Kubernetes Data Service Agent setup in Flyte deployments, including cluster configuration, RBAC setup, and upgrade procedures. Documentation focuses on implementing non-training tasks for data operations, particularly beneficial for deep learning applications. Key improvements include terminology standardization, renaming 'K8s Service Agent' to 'K8s Data Service Agent', and enhanced descriptions of StatefulSet and Service operations.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1