-
Notifications
You must be signed in to change notification settings - Fork 0
Kapellmeister's Errata: Align Our House Score #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8dfbfab
chore(ci/docs): Enforce pedantic rigor and normalize notation
flyingrobots 3e4796e
opus(PR#1): seed rehearsal score (8dfbfab49b290a969ed7bb6248f3880137e…
27b9943
Apply suggestion from @coderabbitai[bot]
flyingrobots 0369361
opus(PR#1): seed rehearsal score (27b99435126e3d7a58706a4f6e0d20a5c02…
85ac499
chore: CodeRabbit feedbacks
flyingrobots 10c2e69
opus(PR#1): seed rehearsal score (85ac499f573fd79192a02aae02d2b0d97fc…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
docs/code-reviews/PR1/8dfbfab49b290a969ed7bb6248f3880137ef177d.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| --- | ||
| title: 8dfbfab49b290a969ed7bb6248f3880137ef177d.md | ||
| description: Preserved review artifacts and rationale. | ||
| audience: [contributors] | ||
| domain: [quality] | ||
| tags: [review] | ||
| status: archive | ||
| --- | ||
|
|
||
| # Code Review Feedback | ||
|
|
||
| | Date | Agent | SHA | Branch | PR | | ||
| |------|-------|-----|--------|----| | ||
| | 2025-09-28 | CodeRabbit (and reviewers) | `8dfbfab49b290a969ed7bb6248f3880137ef177d` | [chore/format](https://github.com/flyingrobots/draft-punks/tree/chore/format "flyingrobots/draft-punks:chore/format") | [PR#1](https://github.com/flyingrobots/draft-punks/pull/1) | | ||
|
|
||
| ## CODE REVIEW FEEDBACK | ||
|
|
||
| ### General comment — coderabbitai[bot] | ||
|
|
||
| ```text | ||
| <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | ||
| <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> | ||
|
|
||
| > [!NOTE] | ||
| > Currently processing new changes in this PR. This may take a few minutes, please wait... | ||
| > | ||
| > <details> | ||
| > <summary>📥 Commits</summary> | ||
| > | ||
| > Reviewing files that changed from the base of the PR and between 5547a98558eff02ecce2a39e40e6813d24516caa and 8dfbfab49b290a969ed7bb6248f3880137ef177d. | ||
| > | ||
| > </details> | ||
| > | ||
| > <details> | ||
| > <summary>📒 Files selected for processing (7)</summary> | ||
| > | ||
| > * `.github/workflows/apply-feedback.yml` (1 hunks) | ||
| > * `.github/workflows/auto-seed-review.yml` (2 hunks) | ||
| > * `.github/workflows/coderabbit-status.yml` (1 hunks) | ||
| > * `.github/workflows/seed-review.yml` (1 hunks) | ||
| > * `Instructions.md` (2 hunks) | ||
| > * `README.md` (3 hunks) | ||
| > * `tools/review/seed_feedback_from_github.py` (1 hunks) | ||
| > | ||
| > </details> | ||
| > | ||
| > ```ascii | ||
| > _________________________________________________________________________________________________________________________________________________________________ | ||
| > < Don't use wizard code you don't understand. Wizards can generate reams of code. Make sure you understand all of it before you incorporate it into your project. > | ||
| > ----------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
| > \ | ||
| > \ \ | ||
| > \ /\ | ||
| > ( ) | ||
| > .( o ). | ||
| > ``` | ||
|
|
||
| <!-- end of auto-generated comment: review in progress by coderabbit.ai --> | ||
|
|
||
|
|
||
| <!-- finishing_touch_checkbox_start --> | ||
|
|
||
| <details> | ||
| <summary>✨ Finishing touches</summary> | ||
|
|
||
| - [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings | ||
| <details> | ||
| <summary>🧪 Generate unit tests</summary> | ||
|
|
||
| - [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests | ||
| - [ ] <!-- {"checkboxId": "07f1e7d6-8a8e-4e23-9900-8731c2c87f58", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Post copyable unit tests in a comment | ||
| - [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Commit unit tests in branch `chore/format` | ||
|
|
||
| </details> | ||
|
|
||
| </details> | ||
|
|
||
| <!-- finishing_touch_checkbox_end --> | ||
|
|
||
| <!-- tips_start --> | ||
|
|
||
| --- | ||
|
|
||
| Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. | ||
|
|
||
| <details> | ||
| <summary>❤️ Share</summary> | ||
|
|
||
| - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) | ||
| - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) | ||
| - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) | ||
| - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) | ||
|
|
||
| </details> | ||
|
|
||
| <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> | ||
|
|
||
| <!-- tips_end --> | ||
| ``` | ||
|
|
||
| _Meta_: https://github.com/flyingrobots/draft-punks/pull/1#issuecomment-3344395219 | ||
|
|
||
| {response} | ||
|
flyingrobots marked this conversation as resolved.
Outdated
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.