feat(a380x/sd): port VIDEO SD page to SDv2 (#10185) - 2020 - #10844
Open
BravoMike99 wants to merge 2 commits into
Open
feat(a380x/sd): port VIDEO SD page to SDv2 (#10185) - 2020#10844BravoMike99 wants to merge 2 commits into
BravoMike99 wants to merge 2 commits into
Conversation
* Port VIDEO SD page * remove from V1 add to V2 * Remove VIDEO and CRUISE from SDv1 * import fixups * add space * remove changelog * add import changes to cruise page * small fixes * more minor fixes * add copyright * Fix page (cherry picked from commit e78fdca)
github-project-automation
Bot
moved this to 🟡 Code Review: Ready for Review
in Quality Assurance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Cherry pick of #10185 to 2020.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
As per original, check that video page works as before (not avail) and that cruise page on SD work correctly.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.