Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-0009] Add CEL library with custom healthchecks to runtime #858

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Jan 24, 2025

runtime/go.mod Outdated Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch from c595d8c to 575c4eb Compare January 24, 2025 08:32
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch 5 times, most recently from 68389f8 to 8b575e6 Compare January 27, 2025 15:22
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch from 8b575e6 to 79a726e Compare January 28, 2025 13:28
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch 4 times, most recently from e9f0be4 to ae32308 Compare January 28, 2025 17:49
@stefanprodan stefanprodan changed the title Add CEL library with custom healthchecks to runtime [RFC-0009] Add CEL library with custom healthchecks to runtime Jan 30, 2025
@matheuscscp matheuscscp force-pushed the custom-healthchecks branch 2 times, most recently from 17a3421 to 30698ce Compare January 30, 2025 10:55
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch 2 times, most recently from 6d64ba0 to f4008e3 Compare January 31, 2025 09:05
Base automatically changed from custom-healthchecks to main January 31, 2025 09:41
@stefanprodan stefanprodan added the area/runtime Controller runtime related issues and pull requests label Jan 31, 2025
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch from f4008e3 to 50e0595 Compare January 31, 2025 09:48
@matheuscscp matheuscscp force-pushed the custom-healthchecks-impl branch from 50e0595 to 62d235c Compare January 31, 2025 10:44
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@matheuscscp matheuscscp merged commit c964ce7 into main Jan 31, 2025
12 checks passed
@matheuscscp matheuscscp deleted the custom-healthchecks-impl branch January 31, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Controller runtime related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants