reconcile: allow atomic reconciliation of release #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
8 times, most recently
from
6adade7 to
8aa3431
Compare
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
927de64 to
c4de611
Compare
|
It is in preparation of, but not solving it by itself. |
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
c4de611 to
0d0d851
Compare
|
@hiddeco do you have any update or ETA for this PR? Thanks! |
|
@faganihajizada It is on this roadmap: https://fluxcd.io/roadmap/#flux-helm-ga-q2-2023 ETA for Q2 2023 - have a happy new year! 🍾 🥳 |
|
Thanks, @kingdonb 🤝 happy new year! 🍾🥳 |
1 task
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
0d0d851 to
3ffa538
Compare
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
3ffa538 to
f9fd4be
Compare
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
2 times, most recently
from
d387e90 to
2b2156b
Compare
darkowlzz
reviewed
Jun 27, 2023
darkowlzz
reviewed
Jun 30, 2023
- Change the map with Helm release test hooks to a pointer map. This allows (in combination with the constrains around JSON serialization) to distinguish a release _without_ a test run from a release _with_ test run but no tests (an empty map). - Add `GetTestHooks` and `SetTestHooks` methods to help circumvent some of the common problems around working with a pointer map in Go (e.g. not being capable of iterating over it using range). - Add `HasBeenTested` and `HasTestInPhase` methods to help make observations on captured release information. - Add `StorageNamespace` to Status to allow for observations of configuration changes which are mutating compared to the spec. - Add `GetActiveRemediation` helper method to get the active remediation strategy based on the presence of Current and/or Previous release observations in the Status of the object. - Add `ReleaseTargetChanged` helper method to determine if an immutable release target changed has occurred, in which case e.g. garbage collection needs to happen before performing any other action. - Add `GetCurrent`, `HasCurrent`, `GetPrevious` and `HasPrevious` helper methods to ease access to their values nested in the Status. - Add `FullReleaseName` and `VersionedChartName` helper methods to e.g. allow printing full name references in Condition and Event messages which can be placed in a point in time based on metadata more familiar to a user than for example the observed generation. - Change `GetFailureCount` and `RetriesExhausted` signatures of `Remediation` interface to take a pointer. This eases use of the API, as generally speaking a (Kubernetes) API object is a pointer. - Move methods from `HelmReleaseSpec` to `HelmRelease`, this is easier to access and matches `GetConditions`, etc. - Remove `DeploymentAction` interface and `GetDescription` from `Remediation` interface as this is no longer of value. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This allows for requesting the count of non-empty values in the ring buffer, and thus the number of log lines. Signed-off-by: Hidde Beydals <[email protected]>
This gives more fine-grain control over what release must be targeted, as we do not always want to rely on the current spec but rather on e.g. a release we have made ourselves with a previous configuration for garbage collection purposes. Signed-off-by: Hidde Beydals <[email protected]>
This solves the issue where a release name composed out of e.g. the target namespace and name of the HelmRelease itself would exceed the >=53 character length. By calculating the SHA256 checksum of the release name, taking the first 12 characters of this checksum and appending it to the release named trimmed to 40 characters separated by a hyphen (`<long-release-name>-abcdef12345678`). Signed-off-by: Hidde Beydals <[email protected]>
This commit adds an atomic release reconciler, capable of stepping through a series of Helm actions. In addition, it adds the last bits around eventing and summarizing the end state of the Condition types into e.g. a Ready condition. Signed-off-by: Hidde Beydals <[email protected]>
This provides more context to individual log entries (and the duration between individual log lines) while e.g. printing them in an event. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This includes the "token" in the emitted events which is used to rate limit events received by the notification-controller. Either by using the already calculated config (values) digest, or by calculating it for the current reconciliation request in scenarios where it isn't available from made observations. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
0a60b54 to
d0b508d
Compare
darkowlzz
approved these changes
Jul 13, 2023
- Use `Unknown` status for the `TestSuccess` condition when tests have not been run yet. - Update Ready summarization logic to incorportate conditions with an Unknown status. Within the context of readiness, this always caises Ready=False when the condition is included in the summarization. - Variety of tiny fixes. - Tiny nits in test mocks to prevent confusion. Signed-off-by: Hidde Beydals <[email protected]>
Manual backport of the work done in #698, to keep things aligned. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
atomic-rls-reconcile
branch
from
d0b508d to
6dcd1e7
Compare
|
Merging this as the CI failure is something that will be addressed by rewriting the actual wiring of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds "atomic release" behavior to the internal reconcilers.
In other words, this means that it determines the current state of the Helm release and decides what action is best to take next, until it has reached the desired state or is not allowed to proceed any further. For example, because of it running a successful upgrade, or having run a remediation action.
In addition to this:
Ready,Stalledand/orProgressingtypes.HelmReleaseinstead ofHelmRelease.Spec.With this added, we can move forward to an actual "main" reconciler implementation and further tidying of the UX.