feat: add WithInMemoryBuild to use virtual filesystem for building kustomizations#5794
Open
rycli wants to merge 5 commits intofluxcd:mainfrom
Open
feat: add WithInMemoryBuild to use virtual filesystem for building kustomizations#5794rycli wants to merge 5 commits intofluxcd:mainfrom
rycli wants to merge 5 commits intofluxcd:mainfrom
Conversation
Author
|
Small note: I see that the DCO workflow is failing... though I added the |
Member
|
See https://github.com/fluxcd/flux2/pull/5794/checks?check_run_id=69071054594 right at the end it tells you the expected signature. |
rycli
force-pushed
the
fix/in-memory-kustomize-build
branch
from
8b4379b to
2ea71a7
Compare
rycli
force-pushed
the
fix/in-memory-kustomize-build
branch
2 times, most recently
from
82f8f57 to
cccf6d1
Compare
rycli
commented
Mar 29, 2026
go.mod
Outdated
| sigs.k8s.io/structured-merge-diff/v6 v6.3.2-0.20260122202528-d9cc6641c482 // indirect | ||
| ) | ||
|
|
||
| replace github.com/fluxcd/pkg/kustomize => github.com/rycli/fluxcd-pkg/kustomize v0.0.0-20260329153243-0671cee33351 |
Author
There was a problem hiding this comment.
Temporary override to allow testing with the proposed changes to pkg/kustomize
rycli
force-pushed
the
fix/in-memory-kustomize-build
branch
from
643b7f7 to
8e290aa
Compare
Author
|
@stefanprodan pushed the tests; I added an extra combination to the existing entries in |
Signed-off-by: rycli <cyril@ryc.li>
Signed-off-by: rycli <cyril@ryc.li>
Signed-off-by: rycli <cyril@ryc.li>
Signed-off-by: rycli <cyril@ryc.li>
Signed-off-by: rycli <cyril@ryc.li>
rycli
force-pushed
the
fix/in-memory-kustomize-build
branch
from
fe0dbae to
5142a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One half of changes necessary to resolve #5781 ; makes use of changes introduced in the
pkgdependency by fluxcd/pkg#1153As suggested, this change keeps the current behavior for building kustomizations internally as part of
flux build kustomization ..., but allows users to opt-in with the--in-memory-buildflag, which will usefilesys.MakeFsInMemory().To keep things a bit cleaner, I opted to add a filesystem "backend" interface; defaults to "on disk", uses "in memory" if opted in. This keeps the rest of the codebase relatively untouched.