Skip to content

Implement RingCentral notifier #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uderik
Copy link

@uderik uderik commented Mar 4, 2025

This adds the ability to send flagger notifications to a RingCentral chat.
Tested in our infrastructure.
RingCentral Incoming Webhooks

Signed-off-by: Denis Kolobnev <[email protected]>
@uderik uderik force-pushed the add-ringcentral-notifier branch from e830901 to 86de823 Compare March 4, 2025 15:26
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.56%. Comparing base (2c4b7a6) to head (86de823).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notifier/ringcentral.go 94.73% 2 Missing and 1 partial ⚠️
pkg/notifier/factory.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
+ Coverage   39.42%   39.56%   +0.13%     
==========================================
  Files         284      285       +1     
  Lines       22422    22481      +59     
==========================================
+ Hits         8840     8894      +54     
- Misses      12632    12636       +4     
- Partials      950      951       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uderik
Copy link
Author

uderik commented Apr 2, 2025

Hi @stefanprodan , what needs to be done for this PR to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants