Do not trigger queries during metadata encoding for (implicitly) ignored items #1473
+266
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilehmann
changed the title
nilehmann
force-pushed
the
push-vmkzyrtksykv
branch
from
30f6519 to
f0256f4
Compare
Member
Author
|
@copilot fix the clippy error in CI |
Contributor
|
@nilehmann I've opened a new pull request, #1477, to work on those changes. Once the pull request is ready, I'll request review from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the set of IDs that have been used in a query. This way, we can collect the transitively set of included items. With this set, we avoid triggering queries for ignored items (not in the set of transitively included items) during metadata encoding. This allows us to remove the HACK in core that avoids metadata encoding.
Note that if a def id is included in the final set without producing errors, this does not mean metadata encoding will succeed for this item. This is because checking may not trigger all queries for that item.