Skip to content

News/flutter news 20250708 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kboy-silvergym
Copy link
Contributor

Description

Types of changes

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)
  • Others (any other types not listed above)

Checklist

  • I have read the Contributing Guide
  • I have added the necessary documentation (if appropriate)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)

Further comments

Related Issue

Closes: #

@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 08:00
@kboy-silvergym kboy-silvergym merged commit 7d1bbaf into feature/uddate_weekly_news Jul 8, 2025
1 check passed
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the frontmatter template and accompanying instructions in the article generator script to use proper YAML delimiters and reorganizes metadata fields.

  • Switched to --- YAML frontmatter block with explicit begin/end markers
  • Reordered and quoted metadata fields (title, slug, author, description, pubDatetime, layout)
  • Enhanced the note about omitting the main title in the article body
Comments suppressed due to low confidence (1)

scripts/generate_article.py:141

  • [nitpick] The title was changed to 週刊ニュース, which no longer matches the previous '週刊開発者ニュース' branding or the flutter-news slug. Consider restoring or including '開発者' or 'Flutter' for consistency.
title: "週刊ニュース {today_str}号"

slug: "flutter-news-{today_str.replace('-', '')}"
author: "kboy"
description: "[今週の主要なトピックを2-3文で要約]"
pubDatetime: "{today_str}"
tags: ["ニュース"]
Copy link
Preview

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags line is unchanged in the diff and missing a + prefix, so it won't be included in the new frontmatter template. Add a + before tags to include it within the YAML block.

Suggested change
tags: ["ニュース"]
+tags: ["ニュース"]

Copilot uses AI. Check for mistakes.

@kboy-silvergym kboy-silvergym deleted the news/flutter-news-20250708 branch July 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant