-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Updating what's new #12656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updating what's new #12656
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining up-to-date release documentation by integrating the latest Flutter 3.38 and Dart 3.10 information into the main 'What's New' page. Concurrently, it ensures proper content lifecycle management by moving the Flutter 3.32 release details to a dedicated archive. The updates encompass new language features, development tool enhancements, platform-specific support, and significant improvements to accessibility documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the 'What's New' pages by archiving the Flutter 3.32 release notes and adding a new entry for the upcoming 3.38 release. My review focuses on identifying placeholder content that must be updated before merging, as well as fixing some typos and inconsistencies in the new markdown content. Several critical placeholders for release-related URLs need to be replaced, and there's a broken link due to a naming mismatch.
src/content/release/whats-new.md
Outdated
| [3.38 release notes and change log]: xxx | ||
| [accessibility docs]: /ui/accessibility | ||
| [bc-3.38]: /release/breaking-changes#released-in-flutter-3-38 | ||
| [Dart 3.10 release]: xxx | ||
| [Dart dot shorthands]: {{site.dart-site}}/language/dot-shorthands | ||
| [DevTools release notes]: xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| Other relevant resources: | ||
|
|
||
| * [3.38 release notes and changelog][] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link reference here is [3.38 release notes and changelog][], but the definition on line 81 is [3.38 release notes and change log]: xxx. The mismatch between changelog and change log will cause the link to be broken. Please make them consistent.
| * [3.38 release notes and changelog][] | |
| * [3.38 release notes and change log][] |
| page for this release. That's also where you'll find useful | ||
| migration info. | ||
|
|
||
| [Architectural overview page]: /resources/architectural-overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link definition for [Architectural overview page] is a duplicate. An identical definition already exists for the 3.29 release section. While this won't break the build, it's redundant and could cause confusion during future maintenance. It's best to remove this duplicate definition and rely on the existing one.
|
|
||
| **Docs updated or added since the 3.35 release** | ||
|
|
||
| * The Dart language now supports _dot shortshands_ syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding info about the update to the websit
|
Visit the preview URL for this PR (updated for commit 96f8347): https://flutter-docs-prod--pr12656-whats-new-7yl0av4y.web.app |
as it says