[camera,video_player] replace onSurfaceDestroyed with onSurfaceCleanup #9316
+61
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matanlurey Have I correctly understood that we no longer need all the save/restore, as discussed in the issue thread? A quick manual test suggests that it works, but I don't know if there were more subtle problems that led to the save/restore approach. |
|
The (implicit - Dart SDK bump) formatter rev makes this harder to review - would you consider doing that in a first PR? |
11 tasks
|
auto-submit bot
pushed a commit
that referenced
this pull request
May 23, 2025
This is a prequel to #9316 to separate out auto-generated changes. All this does is: - Set the minimum SDK version to 3.29. - Run the autoformatter—which changes a ton of things because the 3.29 minimum opts into the new formatter. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
stuartmorgan-g
changed the title
|
Rebased; the Dart changes are gone. |
matanlurey
approved these changes
May 23, 2025
stuartmorgan-g
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces deprecated
onSurfaceDestroyedwithonSurfaceCleanup, which became available in Flutter 3.29 (which these packages require as of #9317).The changes to video player are non-trivial because rather than make the minimal change, this makes the changes discussed in flutter/flutter#160933 (comment) that motivated the change in API in the first place, which simplifies the handling of backgrounding, and restores background playback.
Fixes flutter/flutter#161256
Fixes flutter/flutter#156936
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3