[video_player_android] Add note about Android platform views known issue #9312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
May 23, 2025
| @@ -11,5 +11,10 @@ so you do not need to add it to your `pubspec.yaml`. | |||
| However, if you `import` this package to use any of its APIs directly, you | |||
| should add it to your `pubspec.yaml` as usual. | |||
|
|
|||
| ## Known issues | |||
|
|
|||
| Using `VideoViewType.platformView` is not recommended on Android due to a known [issue][3] affecting platform views on Android. | |||
There was a problem hiding this comment.
How about "not currently recommended"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a README update to flag the known issue regarding the platform view mode implementation. The issue is affecting the optional platform view mode, but the decision is to go ahead with the release including this note. cc: @stuartmorgan-g.
I'm not exactly sure about the versioning regarding this, but I think it should be visible on pub, so bumping the version is IMO appropriate.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3