Skip to content

[camera_avfoundation] Implementation swift migration - part 3.5 #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RobertOdrowaz
Copy link
Contributor

Migrates camera implementation as part of flutter/flutter#119109

This PR consists of everything that was possible to extract from the part 4 which includes:

  • Adds audioCaptureDeviceFactory to FLTCamConfiguration.
  • Renames the lockCaptureOrientation method of Objective-C type FLTCam when exported to Swift.
  • Renames arguments of the captureOutput method of Objective-C type FLTCam when exported to Swift.
  • Changes the connection argument type of the captureOutput method of the of FLTCam class to AVCaptureConnection.
  • Makes minimum/maximumAvailableZoomFactor and minimum/maximumExposureOffset fields of FLTCam readonly.
  • Remove @testable from camera_avfoundation_objc imports

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@RobertOdrowaz RobertOdrowaz force-pushed the feature/camera-implementation-swift-migration-part3-5 branch from 8696776 to 933ccf3 Compare May 23, 2025 09:50
@RobertOdrowaz
Copy link
Contributor Author

@hellohuanlin Please take a look at this when you have some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant