Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jan 9, 2025

Flutter stable 3.27.2 Engine

Scheduled Cherrypicks

Infra Cherrypicks

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino changed the title [flutter_releases] Flutter stable 3.27.0 Engine Cherrypicks [flutter_releases] Flutter stable 3.27.2 Engine Cherrypicks Jan 9, 2025
Copy link
Contributor

@itsjustkevin itsjustkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor Author

Cherrypicked 1af2217 to work around an infra flake.

@christopherfujino
Copy link
Contributor Author

After my infra cherrypick, all the tests completed, but the runner mysteriously exited with -5:

Traceback (most recent call last):
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1395, in <module>
    sys_exit(main())
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1308, in main
    run_cc_tests(build_dir, engine_filter, args.coverage, args.engine_capture_core_dump)
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 512, in run_cc_tests
    run_engine_executable(
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 316, in run_engine_executable
    run_cmd(
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 127, in run_cmd
    raise RuntimeError(
RuntimeError: Command "/Volumes/Work/s/w/ir/cache/builder/src/out/ci/host_profile_arm64_tests/flutter_desktop_darwin_unittests --gtest_repeat=2 --gtest_shuffle" (in /Volumes/Work/s/w/ir/cache/builder/src) exited with code -5.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8726185104050225361/+/u/test:_Host_Tests_for_host_profile/stdout

fixes flutter/flutter#157205

This crashed because ocmock was storing references to rvalues for its
mocked arguments.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
@christopherfujino
Copy link
Contributor Author

Looks like this is: flutter/flutter#157205,

So I am going to cherrypick https://github.com/flutter/engine/pull/55990/files to try to fix.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025
@auto-submit auto-submit bot merged commit e672b00 into flutter:flutter-3.27-candidate.0 Jan 10, 2025
27 checks passed
@christopherfujino christopherfujino deleted the cherrypicks-flutter-3.27-candidate.0 branch January 10, 2025 17:14
@putnokiabel
Copy link

Any ideas on when this might get to stable?
It wasn't clear to me from the documentation how the release process for hotfixes worked after a cherry pick is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants