This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for multi-window dialogs on Windows #56093
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://docs.google.com/document/d/1eQG-IS7r4_S9_h50MY_hSGwUVtgSTRSLzu7MLzPNd2Y/edit?tab=t.0
This PR is a part of a group of PRs. Going from first to last, these must be merged in the following order:
See also the corresponding framework PRs for multi-win support, starting from: flutter/flutter#157515
What's New
This pull request adds support for multi-window dialogs in the Windows embedder.
A new method is available in the
flutter/windowingchannel:createDialog(Map)Mapmust contain the following key-value pairs:String)"parent"int), ornullif the dialog doesn't have a parent"size"List<int>)On success, a
Mapis returned with the following key-value pairs:String)"viewId"int)"archetype"WindowArchetype::dialog"size"List<int>)"parentViewId"int), ornullfor a parentless dialogIf the method fails, a
PlatformExceptionis thrown.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.