-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions list behavior improved #79
Conversation
@luis901101 can you explain your changes to me? you seem to have made a number of them that don't have anything to do with overlapping suggestions, e.g. pulling the geminiApiKey from the environment. can you provide a minimal PR that only addresses the issue at hand? |
|
@csells from our last conversation here and here I just pushed some changes to achieve why we agreed. Basically now the Suggestions will be included in the ListView with the WelcomeMessage if any, this way as you mentioned the scrolling and overlap will be solved. Just one note: the suggestions will be shown below the welcome message instead of above. I think it makes more sense for the suggestions to appear right after the welcome message in the ListView. In fact, once the user taps on a suggestion and sends the message, from the user’s point of view it feels like the suggestion list is replaced by the selected suggestion which, again, I think makes sense. Let me know if anything is not clear or should be different. Here some demos: Welcome.message.with.Suggestions.inside.ListView.mp4Welcome.message.with.a.lot.of.Suggestions.inside.ListView.mp4 |
well done. I think that solves the problems nicely. |
Issues fixed by this PR:
Demos:
Welcome.message.with.Suggestions.mp4
Welcome.message.with.a.lot.of.Suggestions.mp4
Pre-launch Checklist
///
).