-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add printer url in search params so that URLs become bookmarkable #1574
base: develop
Are you sure you want to change the base?
Conversation
Look at search param while loading and use that to find the right config
Hi @andrewboktor, first of all, a big THANK YOU for this PR! I admit I have been working on this for a few months now and my solution was to use the Your approach to altering the main URL (the part before the '#' navigation) is the solution for that problem! I will be taking this PR as base and merging a few changes (I want to try and ensure that page is not reloaded as it currently does, and am considering replacing the btoa with an MD5 hash instead), but it will definitely be based on the work you have provided here! 😀 |
Signed-off-by: Pedro Lamas <[email protected]>
Yea MD5 hash works too, or any other hash for that matter if we want to make the URLs smaller. I do agree that likely the cleanest solution is to add a "printer" as part of the app paths in the router to all the routes. But didn't go that direction because this likely would require touching a lot of code that I'm not familiar with. Please let me know if I can yield any assistance, bounce ideas, or prototype some solution or other. |
I pulled the branch and ran a quick test and it seems to be working well! |
I've been using this on my printer server for about 2 days and it's working as expected |
Add printer url in search params so that URLs become bookmarkable
Look at search param while loading and use that to find the right config
Resolves #677
Signed-off-by: Andrew Boktor [email protected]