Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-211: subtitlesFinder component for a VideoPlayer #125

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

anvk
Copy link
Member

@anvk anvk commented Apr 4, 2013

NOTE: Alex's pull request before leaving. This pull request needs a code review.

http://issues.fluidproject.org/browse/VP-211

anvk and others added 28 commits March 12, 2013 16:15
…l so that transcripts and captions use different data. Make it work. Filter languages which we get from Amara so that local captions/transcripts will have a higher priority.
…video source. Component always creates itself.
…and transcripts if nothing got retrieved from Amara.
Updated the known issues section of the README with some more issues that came up during release testing.
…ration test to reflect that. Also removing timeout from the integration test.
Conflicts:
	js/VideoPlayer_controllers.js
@@ -0,0 +1,60 @@
/*
Copyright 2012 OCAD University
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright data should be 2013

args: ["{arguments}.0"]
}
},
model: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these are in a model, instead of plain default options.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because those values could be changed potentially. There could be the case when the same dataSource would be used to query 2 different webservices. In that case we want to change those values and according to our conventions options block has settings which do not change when state of the component changes

@jobara jobara changed the base branch from master to main October 22, 2020 13:40
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ jobara
✅ michelled
❌ anvk
❌ kmithemanth
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants