feat(helm): add option to disable rbac creation #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbloquel
requested review from
benjaminhuo,
wanjunlei and
wenchajun
as code owners
|
please update here first https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluent-operator-clusterRole.yaml |
|
Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIM
Enable or disable ClusterRole and RoleBinding creation.
The use case is to allow users to use this chart in clusters where creating such objetcs is not allowed by helm deployment.
Also, it's adding the ability to customize the rules, as not all of them are required for the operator to work.
How to use
To use this feature, simply update a propertie in the values.
truefor enable but it's default value.falsefor disable.