fix(fluent-bit): append .Values.labels to all resources#580
Open
lyoung-confluent wants to merge 1 commit intofluent:mainfrom
Open
fix(fluent-bit): append .Values.labels to all resources#580lyoung-confluent wants to merge 1 commit intofluent:mainfrom
lyoung-confluent wants to merge 1 commit intofluent:mainfrom
Conversation
lyoung-confluent
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
Signed-off-by: Luke Young <lyoung@confluent.io>
lyoung-confluent
force-pushed
the
fix-labels
branch
from
b90db43 to
a1d3d00
Compare
stevehipwell
requested changes
Jan 7, 2025
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @lyoung-confluent. I'm happy with this in principal, but could you update Chart.yaml to bump the version and update the change annotations.
Comment on lines
+44
to
+46
| {{- if .Values.labels }} | ||
| {{- toYaml .Values.labels }} | ||
| {{- end }} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {{- if .Values.labels }} | |
| {{- toYaml .Values.labels }} | |
| {{- end }} | |
| {{- with .Values.labels }} | |
| {{- toYaml . }} | |
| {{- end }} |
IMHO this is slightly easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
labelsvalue is added inconsistently to a few resources (DaemonSet,Deployment) but not any of the other resource types. This is annoying if you want to append/enforce a label on all of the resources for this chart, not just the workload resources.This PR moves the labels to the
fluent-bit.labelsnamed template so they will be added to all resources in the chart. Additionally, it adds the include forfluent-bit.labelsto thePodSecurityPolicyresource which was missing it.