Skip to content

output: add metrics for number of stored chunks in secondary #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
This PR will add metrics for number of stored chunks in secondary.
This metrics can be used to determine whether recovery is required from secondary if failure occurs.

Docs Changes:

Release Note:

@Watson1978 Watson1978 force-pushed the add-secondary_chunk_count_metrics branch from 3b11f8c to 6679d83 Compare May 21, 2025 02:52
@Watson1978 Watson1978 marked this pull request as ready for review May 21, 2025 07:38
@Watson1978 Watson1978 requested review from kenhys and daipom May 21, 2025 07:38
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom
Copy link
Contributor

daipom commented May 22, 2025

Hmm, we may need to work out the specifications in more detail.
For example...

  • What this metrics mean exactly:
    • Is it really Number of stored chunks in secondary?
    • Maybe we can express it less misleadingly?
  • The value increases in commit_write, but is it correct?
    • I'm concerned that the backup process calls commit_write as well.
    • What happens if the secondary uses delayed_commit?

For example, if a backup occurs in the secondary and it is also counted up as this metrics, it could be OK as a specification of this metrics.
What we need would be to sort out those specifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants