Repository navigation
in_http: replace WEBrick::HTTPUtils.parse_query with URI - #4900
Merged
Merged
Conversation
WEBrick is no longer recommended for production use. WEBrick::HTTPUtils is just a util, so it might be harmless. However, it would be happy to reduce dependence if possible. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
kenhys
reviewed
Apr 10, 2025
daipom
marked this pull request as draft
April 14, 2025 01:55
daipom
marked this pull request as ready for review
July 29, 2025 01:25
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Replace
WEBrick::HTTPUtils.parse_querywithURI.decode_www_forminin_http.WEBrick is no longer recommended for production use.
WEBrick::HTTPUtilsis just a util, so it might be harmless.However, it would be happy to reduce dependence if possible.
This changes some specifications unintentionally.
At least, this makes us unable to use
;delimitter.We need to consider whether this breaking change is acceptable or not.
Docs Changes:
Not needed.
Release Note:
The same as the title.