-
Notifications
You must be signed in to change notification settings - Fork 1.4k
out_http: TLS1.3 support #4859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
out_http: TLS1.3 support #4859
Conversation
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
@Athishpranav2003 This PR is in draft status. Please let me know if there are any TODO. |
Hey @daipom I guess the pr is left to be tested but I didn't get time to test. Maybe I can check it next week but if someone else can do it as well it will be really helpful. Setting up the openssl thing I didn't try it |
OK! Thanks! |
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
Hey guys i am back, was busy with college. Will look at this pr this week |
Testing output
|
71cb2aa
to
8acba89
Compare
Thanks! We will see this soon! |
If you rebase your commits with master, It will pass tests on Ruby 3.2 / 3.3 Windows. |
Signed-off-by: Athishpranav2003 <[email protected]>
Signed-off-by: Athishpranav2003 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
@Athishpranav2003 Thanks so much for this improvement! The following would be necessary for us.
@Athishpranav2003 |
Sure will do it around this weekend or next week |
@daipom will default tls version stay as tls1.2? |
Thanks!!
Yes! Line 22 in eeb384e
If we change this, it should be done in a separate PR. |
and @daipom what kinda tests to add to test_tls.rb? |
We want some tests for We already have tests for |
Which issue(s) this PR fixes:
Fixes #4332
What this PR does / why we need it:
Changes the way we configure Net::HTTP client.
Docs Changes:
fluent/fluentd-docs-gitbook#579
Release Note:
The same as the title.