Skip to content

ci: skip test when cache is enabled#808

Closed
kenhys wants to merge 1 commit intofluent:masterfrom
kenhys:ci-omit-tests
Closed

ci: skip test when cache is enabled#808
kenhys wants to merge 1 commit intofluent:masterfrom
kenhys:ci-omit-tests

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Apr 7, 2025

It omits redundant tests.

  • Usually source code was changed, and always ci tests them. It might be redundant when it will be tested with subsequent commits during development.
  • When they were cached, ci skip tests. It assumes that CI pass test case in the previous commit
    • If you want to ensure CI results in that commit again, invoke workflow dispatch.

@kenhys kenhys marked this pull request as draft April 7, 2025 07:42
It omit redundant tests.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys marked this pull request as ready for review April 8, 2025 01:48
@kenhys kenhys requested review from Watson1978 and daipom April 8, 2025 01:48
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@daipom
Copy link
Contributor

daipom commented Apr 8, 2025

I understand that we want to skip the build if possible, since it takes a lot of time.
However, I think it’s fine to run the tests every time, even if it feels redundant.

@kenhys
Copy link
Contributor Author

kenhys commented Apr 8, 2025

It might be good for the development phase, but not for production, so I'll close it.

@kenhys kenhys closed this Apr 8, 2025
@kenhys kenhys deleted the ci-omit-tests branch April 10, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants