Skip to content

remove unused defaultSubSecondPrecision const #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove unused defaultSubSecondPrecision const #135

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Contributor

@cosmo0920
Copy link
Contributor

I'm not sure this should be effective but is it safe for removing this parameter?

@thaJeztah
Copy link
Contributor Author

It's not a parameter; it's a non-exported (internal) const that's not used anywhere.

@singholt
Copy link

I think #130 already addressed this: 1f759a4

@thaJeztah
Copy link
Contributor Author

Ah, yes, looks like it; looks like github didn't show that because there's no merge conflict. Let me close this one

@thaJeztah thaJeztah closed this May 19, 2025
@thaJeztah thaJeztah deleted the rm_dead_code branch May 19, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @cosmo0920 @singholt