Skip to content

out_kafka: fix SIGSEGV and memory leak when rd_kafka_new() fails #11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsiper merged 1 commit into from
Jan 12, 2026
+9 −1
Merged

out_kafka: fix SIGSEGV and memory leak when rd_kafka_new() fails #11359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion plugins/out_kafka/kafka_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ struct flb_out_kafka *flb_out_kafka_create(struct flb_output_instance *ins,
}
ctx->ins = ins;
ctx->blocked = FLB_FALSE;
mk_list_init(&ctx->topics);

ret = flb_output_config_map_set(ins, (void*) ctx);
if (ret == -1) {
Expand Down Expand Up @@ -239,9 +240,13 @@ struct flb_out_kafka *flb_out_kafka_create(struct flb_output_instance *ins,
if (!ctx->kafka.rk) {
flb_plg_error(ctx->ins, "failed to create producer: %s",
errstr);
rd_kafka_conf_destroy(ctx->conf);
ctx->conf = NULL;
flb_out_kafka_destroy(ctx);
return NULL;
}
/* rd_kafka_new() succeeded, conf ownership transferred to rk */
ctx->conf = NULL;

#ifdef FLB_HAVE_AVRO_ENCODER
/* Config AVRO */
Expand All @@ -256,7 +261,6 @@ struct flb_out_kafka *flb_out_kafka_create(struct flb_output_instance *ins,
#endif

/* Config: Topic */
mk_list_init(&ctx->topics);
tmp = flb_output_get_property("topics", ins);
if (!tmp) {
flb_kafka_topic_create(FLB_KAFKA_TOPIC, ctx);
Expand Down Expand Up @@ -304,6 +308,10 @@ int flb_out_kafka_destroy(struct flb_out_kafka *ctx)
rd_kafka_destroy(ctx->kafka.rk);
}

if (ctx->conf) {
rd_kafka_conf_destroy(ctx->conf);
}

if (ctx->opaque) {
flb_kafka_opaque_destroy(ctx->opaque);
}
Expand Down
Loading