Skip to content

go: plugin_proxy: error on plugin initialization errors #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

go: plugin_proxy: error on plugin initialization errors #10354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc46abc
input_thread: exit on failures to initialize threaded plugin instances
stoksc May 22, 2025
9ec44d5
proxy: go: don't free plugin twice
stoksc May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/flb_input_thread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,11 @@ int flb_input_thread_instance_init(struct flb_config *config, struct flb_input_i
ret = input_thread_instance_get_status(ins);
if (ret == -1) {
flb_plg_error(ins, "unexpected error loading plugin instance");
return -1;
}
else if (ret == FLB_FALSE) {
flb_plg_error(ins, "could not initialize threaded plugin instance");
return -1;
}
else if (ret == FLB_TRUE) {
flb_plg_info(ins, "thread instance initialized");
Expand Down
1 change: 0 additions & 1 deletion src/proxy/go/go.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ int proxy_go_input_init(struct flb_plugin_proxy *proxy)
if (ret <= 0) {
flb_error("[go proxy]: plugin '%s' failed to initialize",
plugin->name);
flb_free(plugin);
return -1;
}

Expand Down
Loading