Skip to content

Kubernetes filter for style #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

esmerel
Copy link
Contributor

@esmerel esmerel commented May 20, 2025

Update kubernetes filter page for style

Signed-off-by: Lynette Miles <[email protected]>
@esmerel esmerel requested review from a team as code owners May 20, 2025 22:23
couple of tweaks that need fixing


Signed-off-by: Lynette  Miles <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Lynette  Miles <[email protected]>
@esmerel esmerel merged commit 31150bc into master May 20, 2025
5 checks passed
@esmerel esmerel deleted the lynettemiles/sc-136149/update-fluent-bit-docs-pipeline-filters-kubernetes branch May 20, 2025 23:51
Copy link
Contributor

@gguillotte gguillotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to move forward; many non-blocking suggestions. The PR introduces an unclosed formatting issue on line 39, a typo on line 84, and an extraneous word on line 100.


In some cases, you may only see some objects being appended with metadata while other objects are not enriched. This can occur at times when local data is cached and does not contain the correct id for the kubernetes object that requires enrichment. For most Kubernetes objects the Kubernetes API server is updated which will then be reflected in Fluent Bit logs, however in some cases for `Pod` objects this refresh to the Kubernetes API server can be skipped, causing metadata to be skipped.
In some cases, you might only see some objects being appended with metadata while other objects aren't enriched. This can occur at times when local data is cached and doesn't contain the correct id for the Kubernetes object that requires enrichment. For most Kubernetes objects the Kubernetes API server is updated which will then be reflected in Fluent Bit logs. In some cases for `Pod` objects this refresh to the Kubernetes API server can be skipped, causing metadata to be skipped.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: Phrasing, capitalize ID

Suggested change
In some cases, you might only see some objects being appended with metadata while other objects aren't enriched. This can occur at times when local data is cached and doesn't contain the correct id for the Kubernetes object that requires enrichment. For most Kubernetes objects the Kubernetes API server is updated which will then be reflected in Fluent Bit logs. In some cases for `Pod` objects this refresh to the Kubernetes API server can be skipped, causing metadata to be skipped.
In some cases, you might see only some objects being appended with metadata while other objects aren't enriched. This can occur when local data is cached and doesn't contain the correct ID for the Kubernetes object that requires enrichment. For most Kubernetes objects the Kubernetes API server is updated, which will then be reflected in Fluent Bit logs. In some cases for `Pod` objects, this refresh to the Kubernetes API server can be skipped, causing metadata to be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants