added multiple query properties #4041
Open
+1,644
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WelschChristopher
force-pushed
the
added-multiple-query-parameter
branch
from
df37a4c to
1f408ec
Compare
filiphr
requested changes
Apr 9, 2025
There was a problem hiding this comment.
I've left some comments that should be addressed.
On top of that, we need to do changes in DeleteHistoricCaseInstancesUsingBatchesCmd, BatchDeleteCaseConfig, DeleteHistoricProcessInstancesUsingBatchesCmd and BatchDeleteProcessConfig in order to add the new methods.
...able-cmmn-api/src/main/java/org/flowable/cmmn/api/history/HistoricPlanItemInstanceQuery.java
Outdated
Show resolved
Hide resolved
...flowable-cmmn-engine/src/main/resources/org/flowable/cmmn/db/mapping/entity/CaseInstance.xml
Outdated
Show resolved
Hide resolved
...-cmmn-engine/src/main/resources/org/flowable/cmmn/db/mapping/entity/HistoricCaseInstance.xml
Outdated
Show resolved
Hide resolved
...able-cmmn-engine/src/test/java/org/flowable/cmmn/test/runtime/CaseInstanceQueryImplTest.java
Outdated
Show resolved
Hide resolved
...n-engine/src/test/java/org/flowable/cmmn/test/history/HistoricCaseInstanceQueryImplTest.java
Outdated
Show resolved
Hide resolved
...lowable-engine/src/main/resources/org/flowable/db/mapping/entity/HistoricProcessInstance.xml
Outdated
Show resolved
Hide resolved
...-cmmn-engine/src/main/resources/org/flowable/cmmn/db/mapping/entity/HistoricCaseInstance.xml
Outdated
Show resolved
Hide resolved
...lowable-engine/src/main/resources/org/flowable/db/mapping/entity/HistoricProcessInstance.xml
Outdated
Show resolved
Hide resolved
...vice/src/main/resources/org/flowable/task/service/db/mapping/entity/HistoricTaskInstance.xml
Outdated
Show resolved
Hide resolved
...vice/src/main/resources/org/flowable/task/service/db/mapping/entity/HistoricTaskInstance.xml
Outdated
Show resolved
Hide resolved
dbmalkovsky
reviewed
Apr 9, 2025
modules/flowable-engine/src/test/java/org/flowable/engine/test/api/task/TaskQueryTest.java
Outdated
Show resolved
Hide resolved
dbmalkovsky
reviewed
Apr 9, 2025
...task-service/src/main/java/org/flowable/task/service/impl/HistoricTaskInstanceQueryImpl.java
Outdated
Show resolved
Hide resolved
dbmalkovsky
reviewed
Apr 9, 2025
modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/TaskQueryImpl.java
Outdated
Show resolved
Hide resolved
WelschChristopher
force-pushed
the
added-multiple-query-parameter
branch
6 times, most recently
from
489df0c to
8411991
Compare
added query parameter for case, processes, tasks, plan items and the historic variants changes according to comments fixed testcases
WelschChristopher
force-pushed
the
added-multiple-query-parameter
branch
from
8411991 to
e7cf41f
Compare
filiphr
requested changes
Apr 11, 2025
There was a problem hiding this comment.
I've added one more comment, there is some duplicated code.
Apart from that the ProcessInstanceQueryTest and HistoricActivityInstanceTest, from what I can see, are going to pass even if you do not do any query in the mybatis XML. I think that we should have more data and validate that we are only getting part of the data
...n/java/org/flowable/rest/service/api/history/HistoricActivityInstanceCollectionResource.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added query parameter for case, processes, tasks, plan items and the historic variants
Check List: