Added a helper function to find out egress port #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case takes lb_port as input. Since the test case tries to send data back to lb_port +1, the test case fails and switch generates dumps. ["Unconfigured port received"], this is because if I supply lb_port (say 102), 103 may/may not be a valid port of the configuration. The fixes done by me will eliminate this issue. More details explained in comments.
This reverts commit eea379c.
This test case lb_port as input. This lb_port (provided by the user) acts as an ingress port at the switch. However the test case tries to send the packet back to the controller through lb_port+1 which is not always true. Say I supplied lb_port 102, but 103 may/may not be a part of an openflow configuration. The fixes shown takes care of this issue.
This reverts commit 8c03821.
This test case takes lb_port as input. This lb_port (provided by the user) acts as an ingress port at the switch. However the test case tries to send the packet to the controller through port lb_port+1, which is a serious bug here, because say 102 is my lb_port, then 103 may/may not be a part of an openflow configuration. The fixes done by me will take care of this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for frequent commits and reverts. These were done just to erase the changes that were irrelevant to the issue. Issue explained in the commit statement. The commit b1ad29b is the only relevant commit.