Allow format specifier for all date/time types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qxjit
approved these changes
Apr 18, 2024
| , deriveClasses : DeriveClasses | ||
| } | ||
| , default = | ||
| { dateTimeFormat = DateTimeFormat.UTCTime | ||
| , dateFormat = DateFormat.ISO8601Date | ||
| , formatSpecifier = None Text |
There was a problem hiding this comment.
It's unfortunate to lose the the meaning of the default from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas
This generalizes the implementation of
dayWithFormatas a new function calledtimeWithFormat.To improve usability, I've added less polymorphic versions of it like e.g.
dayWithFormat,utcTimeWithFormatetc.In codegen
The previous DateFormat type is unnecessary because there is only one type to choose for dates: Data.Time.Day.
Now that the
formatSpecifieris possible for bothdates anddate-times, it has been moved up to theTypeOptionsrecord.