Allow boundedEnum to accept a parameter to modify text beforehand #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This let's us handle an enum where the input text may not exactly match the toText values but can be converted to them (such as converting to lower case values).
qxjit
reviewed
Feb 23, 2024
| @@ -154,7 +154,7 @@ instance FC.Fleece Decoder where | |||
| Decoder name $ | |||
| Aeson.withObject (FC.nameToString name) parseObject | |||
|
|
|||
| boundedEnumNamed name toText = | |||
| boundedEnumNamedModifyText name toText modifyText = | |||
There was a problem hiding this comment.
I think I'd like to handle this a different way.
|
I'd like to note that this wouldn't be necessary if we made boundedEnum non-type-class based, because then I imagine that you could wrap the converter functions passed into that hypothetical schema with |
|
Closing as this is probably better handled as a enum utility function in a different library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let's us handle an enum where the input text may not exactly match the toText values but can be converted to them (such as converting to lower case values).