Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add perfectionnist to eslint config #253

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Conversation

MatthysDev
Copy link
Collaborator

Closes: #251

@MatthysDev MatthysDev requested a review from flexbox September 3, 2024 14:43
@MatthysDev MatthysDev marked this pull request as ready for review September 3, 2024 14:43
@MatthysDev
Copy link
Collaborator Author

MatthysDev commented Sep 3, 2024

I think we can do something with .github/workflows/readme-checker.yml / lint (pull_request) to avoid the check error on each pull request @flexbox

hackathon/spacecraft/package.json Outdated Show resolved Hide resolved
hackathon/spacecraft/src/hooks/usePlanets.ts Outdated Show resolved Hide resolved
@flexbox
Copy link
Owner

flexbox commented Sep 4, 2024

@MatthysDev
for the markdown linting error can you disable the line-width?
https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.jsonc

@flexbox flexbox force-pushed the feat/perfectionnist branch from 830deb5 to ecba9a1 Compare September 17, 2024 07:09
@flexbox flexbox force-pushed the feat/perfectionnist branch from 06aca01 to 5aeb19f Compare September 17, 2024 09:57
@flexbox flexbox force-pushed the feat/perfectionnist branch from 5aeb19f to e0db0d5 Compare September 17, 2024 10:16
@flexbox flexbox merged commit 926e43b into main Sep 17, 2024
1 check passed
@flexbox flexbox deleted the feat/perfectionnist branch September 17, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We are ESLint perfectionnists
2 participants