fix(auth): Honor deployment scope on keys minted by admin users#132
Merged
Conversation
A deployment-scoped API key minted by an admin user was rejected with 403 when used. The check required an explicit per-deployment grant on the underlying user record, which admin users do not have because their access is granted implicitly by role. Admins now satisfy the user side of the check unconditionally, and the key's per-deployment scope is applied as a cap on top, so a scoped key works as intended from any user role. The mirror condition is fixed too: an admin-role key with a per-deployment scope is now capped by that scope rather than short-circuiting the check. A scoped key cannot grant more access than either side of the pair allows; the effective level is the lower of the two.
Code Review SummaryThis PR successfully addresses a bug where deployment-scoped API keys minted by administrators were incorrectly rejected. It also strengthens security by ensuring that any scoped key acts as a 'cap' on the user's permissions, rather than a separate grant. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deployment-scoped API key minted by an admin user was rejected with 403 when used. The check required an explicit per-deployment grant on the underlying user record, which admin users do not have because their access is granted implicitly by role. Admins now satisfy the user side of the check unconditionally, and the key's per-deployment scope is applied as a cap on top, so a scoped key works as intended from any user role.
The mirror condition is fixed too: an admin-role key with a per-deployment scope is now capped by that scope rather than short-circuiting the check. A scoped key cannot grant more access than either side of the pair allows; the effective level is the lower of the two.