Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow draft #629

Draft
wants to merge 99 commits into
base: master
Choose a base branch
from

Conversation

DiamonDinoia
Copy link
Collaborator

@janden this is the draft for the workflow for python wheels. No idea if it works but it should install the required dependencies.

Cheers!

@DiamonDinoia DiamonDinoia marked this pull request as draft February 12, 2025 00:47
@DiamonDinoia DiamonDinoia changed the title wodkflow draft workflow draft Feb 12, 2025
@janden
Copy link
Collaborator

janden commented Feb 13, 2025

Thanks! Will take a look.

@janden
Copy link
Collaborator

janden commented Feb 14, 2025

@DiamonDinoia I'm a bit confused. I was under the impression that we were talking about setting up a workflow for compiling the cufinufft binary wheels on GHA. But this modifies the wheel-building script for finufft. What is the goal exactly here?

@DiamonDinoia
Copy link
Collaborator Author

DiamonDinoia commented Feb 14, 2025

@DiamonDinoia I'm a bit confused. I was under the impression that we were talking about setting up a workflow for compiling the cufinufft binary wheels on GHA. But this modifies the wheel-building script for finufft. What is the goal exactly here?

Okay, now is clear. I thought that this workflow was not used hence I modified it.
My goal is to have a workflow that builds all the artifacts in one go. python, matlab and so on.

I apologize I completely misunderstood. I did not know that this workflow generated the finufft wheel that you upload. My understanding was that you generated them by hand.

The end goal for me would be to have a workflow that builds all the artifacts. But this does not need to happen now. We have two options here for now:

  1. restore this workflow as it was and create a new one for cufinufft (python)
  2. update this one to build both.

I thought this was not used because windows wheels here are build with mingw instead of native llvm/msvc.
Let me know what you think is best.

Cheers,
Marco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants