Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG #613

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

janden
Copy link
Collaborator

@janden janden commented Jan 28, 2025

Missing from PRs #606 and #608.

@janden janden requested a review from ahbarnett January 28, 2025 21:25
Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joakim - great, Alex

CHANGELOG Outdated
@@ -40,6 +40,10 @@ Master, using release name V 2.4.0 (1/7/25)
* Add options for user-provided FFTW locker (PR548, Blackwell). These options
can be be used to prevent crashes when a user is creating/destroying FFTW
plans and FINUFFT plans in threads simultaneously.
* Make attributes private in Python Plan classes and allow read-only access to
them using properties.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add the PR #s that would be great. Still wrap lines at 80 chars.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I've tended to add the new stuff at the top not the bottom of the current list.

@ahbarnett ahbarnett merged commit cdfaa8c into flatironinstitute:master Feb 11, 2025
12 of 13 checks passed
@janden janden deleted the joakim_missing_changelog branch February 14, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants