WIP: CNMF.initialization.greedyROI() - Add a limited mechanism to specify params in calls to sklearn's NMF #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mechanism to greedyROI() to allow overriding of calls to sklearn's NMF(), passing in overrides as a dict.
(it also, as usual, includes some minor cleanups I spotted while looking at the code).
Will be WIP until the mechanism is plumbed up to CNMFParams, which will go through initialization.py:initialize_components() as well as utilities.py:manually_refine_components() although we may decide not to do it for the latter one maybe.
I went back-and-forth over whether to go with a dict or pass in params individually, but I think grouping them at least at this level is a little closer to where we eventually want to be - passing a structured deep dictionary parameters object around rather than having dozens of arguments everywhere and unwieldy gigantic signatures to all functions/methods.