Skip to content

Fix: Verify scales are not None for Cutlass FP8 FusedMoE #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix: Verify scales are not None for Cutlass FP8 FusedMoE #1961

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bce8ff
Verify scales are not None for Cutlass FP8 FusedMoE
amirkl94 Oct 21, 2025
dd1864b
Fix error message
amirkl94 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions csrc/fused_moe/cutlass_backend/flashinfer_cutlass_fused_moe_sm100_binding.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,13 @@ class FusedMoeRunner : public tvm::ffi::ModuleObj {
auto const fc2_dequant = quant_scales.value()[2];
auto const fc1_input_dequant = quant_scales.value()[3];

TVM_FFI_ICHECK(fc1_dequant.get() != nullptr) << "Expecting fc1_dequant to be non null";
TVM_FFI_ICHECK(fc2_quant.get() != nullptr) << "Expecting fc2_quant to be non null";
TVM_FFI_ICHECK(fc2_dequant.get() != nullptr)
<< "Expecting fc1fc2_dequant_dequant to be non null";
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There appears to be a copy-paste error in this error message. It should refer to fc2_dequant to match the variable being checked.

      TVM_FFI_ICHECK(fc2_dequant.get() != nullptr)
          << "Expecting fc2_dequant to be non null";

Copy link
Collaborator

@yongwww yongwww Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls take a look at this comment from gemini

TVM_FFI_ICHECK(fc1_input_dequant.get() != nullptr)
<< "Expecting fc1_input_dequant to be non null";

// Check types
CHECK_INPUT_TYPE(fc1_dequant, dl_float32);
CHECK_INPUT_TYPE(fc2_quant, dl_float32);
Expand Down