Skip to content

Conversation

@fkondej
Copy link

@fkondej fkondej commented Jan 9, 2026

No description provided.

@fkondej fkondej requested a review from bakhtin January 9, 2026 11:34
@fkondej fkondej self-assigned this Jan 9, 2026
.SHELLFLAGS := -eu -o pipefail -c

# mkosi version
MKOSI_COMMIT := a425313c5811d2ed840630dbfc45c6bc296bfd48
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets avoid putting project dependency versions in the Makefile. main branch is using Nix which I think is too heavy for bnet images use-case (we don't need to install system tools).

Below you're also opting to use pip for dependency management. Originally, I intentionally avoided relying on any single tool for Python dependency management as there is no one blessed tool in the Python ecosystem and people use whatever (pip, pipx, poetry, uv).

Let's first discuss which dependency management tool we want to use for the project. I personally like uv.

To not block the PR on the tool selection decision let's proceed with the current implementation of the Makefile and come back to it later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added TODO to the Makefile to revisit tooling choice.


cd ${OUTPUTDIR}
qemu-img convert -f raw -O qcow2 ${OUTPUTDIR}/${IMAGE_ID}_${IMAGE_VERSION}.raw ${OUTPUTDIR}/${IMAGE_ID}_${IMAGE_VERSION}.qcow2
rm -f ${OUTPUTDIR}/${IMAGE_ID}_${IMAGE_VERSION}.raw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using .raw image in playground.
Hmm, let me switch to qcow2. Is that ok?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted and switched to qcow2.

@@ -0,0 +1,3 @@
[Service]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

[Content]
Autologin=true

should solve it as in the local profile

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check this approach

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to mkosi configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants