This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
Changes to DownloadUrlResolver #333
Open
anilgit90
wants to merge
16
commits into
flagbug:master
Choose a base branch
from
anilgit90:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilgit90
commented
Dec 17, 2018
- Changed signature resolving.
- Changed player regex url resolver.
1. Changed signature resolving. 2. Changed player regex url resolver.
This was referenced Dec 17, 2018
Closed
1. Updated ExampleApplication to support GUI example 2. Added the project in Main Project Solution.
1. Added Application Icon 2. Exported Project Dependencies to Common Folder 3. Initial Appveyor Script for CI.
Nice job dude! Will try and code-review/test your changes sometime next week or post Christmas. |
1. Added Progress bar to update the download progress of the video. 2. Updated readme to include feature list of Sample GUI.
Hello, self problem with: https://www.youtube.com/watch?v=G4mlA65wsbE public static string DecipherWithVersion(string cipher, string cipherVersion)
404 file not found jsUrl |
1. Changed Decipherer.cs to Include changes to Youtube Player Url. 2. Updated Readme to include badge in new line.
Added Analysis of code by BetterCode.
This did not download https://www.youtube.com/watch?v=7rwW1ErcVu8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.