Added support for Vorbis video, Opus audio and 60fps #227
Conversation
… HD formats that are only available by parsing the Dash Manifest. Added ProgressEventArgs.ProgressBytes.
|
I forgot one line of code to set DownloadSize. Must add this in VideoDownloader.cs line 47, just after response.GetResponseStream() DownloadSize = (int)response.ContentLength; |
|
I had this JObject errors too when I upgraded the Json.Net package. Perhaps just rollback the nuget package update for json.net? |
| <Reference Include="Newtonsoft.Json, Version=4.5.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
| <HintPath>..\packages\Newtonsoft.Json.5.0.8\lib\net35\Newtonsoft.Json.dll</HintPath> | ||
| <Reference Include="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\NaturalGroundingPlayer\packages\Newtonsoft.Json.9.0.1\lib\net35\Newtonsoft.Json.dll</HintPath> |
There was a problem hiding this comment.
Should be <HintPath>..\packages\Newtonsoft.Json.9.0.1\lib\net35\Newtonsoft.Json.dll</HintPath> instead.
|
There are actually 4 Problems with this PR:
|
| DecryptDownloadUrl(info); | ||
|
|
||
| var request = (HttpWebRequest)WebRequest.Create(info.DownloadUrl); | ||
| using (WebResponse response = request.GetResponse()) { |
There was a problem hiding this comment.
We should use request.BeginGetResponse() here instead.
|
@mysteryx93 How do you deal with partial dash streams (ones that only have content for a particular segment in the timeline)? I don't see anything about it in code. |
|
Partial DASH streams? Never heard of that. There are still a few features missing. |
|
@mysteryx93 they are the ones that have "sq/" in |
Added support for Vorbis video, Opus audio, 60fps, as well as various HD formats that are only available by parsing the Dash Manifest. Added ProgressEventArgs.ProgressBytes.
Note: since recently, YouTube returns (409) Forbidden. This merge does not solve this problem.